Fix ContentTypeId conflict #3967
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3967 +/- ##
============================================
+ Coverage 63.58% 63.58% +<.01%
Complexity 100 100
============================================
Files 720 720
Lines 31838 31839 +1
Branches 5113 5114 +1
============================================
+ Hits 20245 20246 +1
Misses 9273 9273
Partials 2320 2320
Continue to review full report at Codecov.
|
| /** | ||
| * Serizlization ContentTypeId | ||
| */ | ||
| public static final byte AVRO_SERIALIZATION_ID = 1; |
There was a problem hiding this comment.
public static final byte AVRO_SERIALIZATION_ID = 11 should be better
There was a problem hiding this comment.
public static final byte AVRO_SERIALIZATION_ID = 11 should be better
What are the uses of 1 and 5 here?
There was a problem hiding this comment.
let's simply leave it as is. I believe the original intention is: 1, 2, 4, 8, 16...
| public static final byte PROTOSTUFF_SERIALIZATION_ID = 10; | ||
| public static final byte AVRO_SERIALIZATION_ID = 11; | ||
| public static final byte GSON_SERIALIZATION_ID = 16; | ||
|
|
There was a problem hiding this comment.
Maybe you can define a sub-constant class. What do you think?
There was a problem hiding this comment.
+1 for a specific constants class
There was a problem hiding this comment.
I think this suggestion is good, I will modify it later.
What is the purpose of the change
Fix Serialization ContentTypeId conflict between avro protocol and protocoluff protocol #3926
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.